Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add boolean null state #4583

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

MaxPostema
Copy link
Contributor

@MaxPostema MaxPostema commented Dec 24, 2024

fixes: #4580

What are the main changes you did

  • a boolean input had a broken state. It will now start unselected until a user choses a state for it.

How to test

  • have a boolean field, see that the boolean is unselected when creating a new record.

Copy link

@Fernananas Fernananas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix to add a boolean null state works as expected. I tested the following scenarios:

  • Boolean is empty when the form is opened.
  • Behavior when the field is marked as required.
  • Functionality with default values applied.
  • Use of this field in visible expressions.

All tests passed without issues. The fix resolves the described problem.

@MaxPostema MaxPostema merged commit c9335e4 into master Jan 2, 2025
7 checks passed
@MaxPostema MaxPostema deleted the fix/boolean-can-also-be-null branch January 2, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultValue for Boolean datatypes is broken
2 participants