Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: copy all test results to results folder #4557

Merged
merged 3 commits into from
Dec 18, 2024
Merged

chore: copy all test results to results folder #4557

merged 3 commits into from
Dec 18, 2024

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Dec 11, 2024 •
edited
Loading

What are the main changes you did

  • e2e test run in app folder ( for easy local test writing), this pr copies the results to top level job so the circle-ci ui can pick up the results

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@connoratrug connoratrug marked this pull request as ready for review December 13, 2024 15:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chinook25
chinook25 reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@chinook25 chinook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but not sure on how to test it.

@connoratrug connoratrug merged commit b51072a into master Dec 18, 2024
7 checks passed
@connoratrug connoratrug deleted the chore/store-e2e-test-results branch December 18, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinook25 chinook25 chinook25 left review comments

@mswertz mswertz Awaiting requested review from mswertz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connoratrug @chinook25