Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(directory): add the select all buttons #4556

Merged
merged 12 commits into from
Dec 18, 2024

Conversation

MaxPostema
Copy link
Contributor

@MaxPostema MaxPostema commented Dec 11, 2024

fixes: 814

What are the main changes you did

  • added a Select all services button
  • added a Select all collections button
  • buttons only show if a filter is set
  • buttons hide if there are 0 items it could select
  • aligned search field to filters below
  • added 'no-wrap' to buttons with 'badge' ( in situations with limited space the buttons would take 2 lines )

How to test

see issue 814

Checklist

  • Make the buttons work
  • Maybe hide the button if everything it can select is selected?
  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@MaxPostema MaxPostema marked this pull request as ready for review December 13, 2024 08:26
connoratrug

This comment was marked as resolved.

Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but for me it would be logical if the button would change to deselect all if all are selected, but that can be addressed in a new story, since there is a workaround with the remove all button in the request basket.

@connoratrug connoratrug merged commit 7f0dd00 into master Dec 18, 2024
6 of 7 checks passed
@connoratrug connoratrug deleted the fix/add_select_all_buttons branch December 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants