Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tasks): also send failure mails when failing jobs are scheduled #4554

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fix(tasks): also send failure mails when failing jobs are scheduled #4554

merged 3 commits into from
Dec 17, 2024

Conversation

harmbrugge
Copy link
Member

@harmbrugge harmbrugge commented Dec 11, 2024 •
edited
Loading

Fixes #4542

What are the main changes you did

  • Fixed sending failure mails when failing jobs are scheduled
  • By storing the host url in WebService and passing it the TaskService

How to test

  • Can only be tested on prod/acc server

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

mswertz
mswertz approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. If you have functional approval then pls merge :-)

@harmbrugge harmbrugge merged commit 4e9f3de into master Dec 17, 2024
6 of 7 checks passed
@harmbrugge harmbrugge deleted the fix/task-scedule-fail-mail branch December 17, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

@connoratrug connoratrug Awaiting requested review from connoratrug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: failure email doesn't work when script is scheduled
2 participants
@harmbrugge @mswertz