-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Load images from application jar #4389
Conversation
getBinaryFileWrapper impl did not work within jar file ( ci and prod runs as jar) by skipping to getResourceAsStream the file van be read from the jar, but folder can not be listed this way either pas file name ( extentions and type ) to getBinaryFileWrapper or find a way to scan the files with in the jar
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things.
And I would move the file_image to the pet_store profile
...is-emx2-io/src/main/java/org/molgenis/emx2/io/tablestore/TableStoreForCsvFilesClasspath.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better to move the file to the pet_store profile. Adding a profile for just testing is a bit much
...is-emx2-io/src/main/java/org/molgenis/emx2/io/tablestore/TableStoreForCsvFilesClasspath.java
Show resolved
Hide resolved
close in favour of : #4393 |
What are the main changes you did:
Closes #3512
how to test:
Use the 'IMAGE_TEST' profile and include the demodata to test with minimal example, this profile can be removed after initial review and we can extend the catalogue example to include images
See: #4393 for fix ( excludes 'IMAGE_TEST' from options list in create modal)
todo: