fix: Load images from application jar #4389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getBinaryFileWrapper impl did not work within jar file ( ci and prod runs as jar) by skipping to getResourceAsStream the file van be read from the jar, but folder can not be listed this way either pas file name ( extentions and type ) to getBinaryFileWrapper or find a way to scan the files with in the jar
connoratrug
changed the title
|
harmbrugge
reviewed
Oct 24, 2024
...is-emx2-io/src/main/java/org/molgenis/emx2/io/tablestore/TableStoreForCsvFilesClasspath.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Maybe better to move the file to the pet_store profile. Adding a profile for just testing is a bit much
...is-emx2-io/src/main/java/org/molgenis/emx2/io/tablestore/TableStoreForCsvFilesClasspath.java
Show resolved
Hide resolved
|
close in favour of : #4393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
Closes #3512
how to test:
Use the 'IMAGE_TEST' profile and include the demodata to test with minimal example, this profile can be removed after initial review and we can extend the catalogue example to include images
See: #4393 for fix ( excludes 'IMAGE_TEST' from options list in create modal)
todo: