Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalogue): fix 4366 #4377

Conversation

connoratrug
Copy link
Contributor

'overview' check expected resourceType not set in variable route Closes #4366

What are the main changes you did:

  • add check for variable route

how to test:

  • compare variable route menu with resource route menu , should now both have the overview link

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

'overview' check expected resourceType not set in variale route
Closes #4366
Copy link

sonarcloud bot commented Oct 17, 2024

@connoratrug connoratrug merged commit a820887 into master Oct 17, 2024
6 checks passed
@connoratrug connoratrug deleted the 4366-fixcatalogue-menu-ribbon-is-inconsistent-across-the-different-resource-types branch October 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(catalogue): Menu ribbon is inconsistent across the different resource types.
2 participants