Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalogue): add missing resource types and otherwise use raw type name #4348

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Oct 13, 2024

@connoratrug
Copy link
Contributor

https://preview-emx2-pr-4348.dev.molgenis.org/catalogue-demo/ssr-catalogue/all

shows 'clinical trail' instead of expected 'clinical trails' , the paths ( routes of the other types are , all lowercase no whitespace ( for example ssr-catalogue/all/datasources ) but clinical trail has a path of 'sr-catalogue/all/Clinical%20trial'

@mswertz
Copy link
Member Author

mswertz commented Oct 16, 2024

https://preview-emx2-pr-4348.dev.molgenis.org/catalogue-demo/ssr-catalogue/all

shows 'clinical trail' instead of expected 'clinical trails' , the paths ( routes of the other types are , all lowercase no whitespace ( for example ssr-catalogue/all/datasources ) but clinical trail has a path of 'sr-catalogue/all/Clinical%20trial'

Indeed. If all is well this is now fixed.
Also enable special rule for resourceType == 'resources' which we will need to show all results.

@mswertz mswertz marked this pull request as draft October 16, 2024 08:02
@mswertz mswertz marked this pull request as ready for review October 16, 2024 10:17
@mswertz mswertz requested a review from hslh October 16, 2024 10:19
Copy link

sonarcloud bot commented Oct 17, 2024

Copy link
Contributor

@hslh hslh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on the preview server. Perhaps out of the scope of this PR, but the label below the resource logo and count is still default 'Cohorts & Biobanks'. Perhaps change this to use the raw type name instead so it at least matches the name?

@mswertz
Copy link
Member Author

mswertz commented Oct 17, 2024

ut the label below the resource logo and count is still default 'Cohorts & Biobanks'. Perhaps change this to use the raw type name instead so it at least matches the name?

indeed. done.

@mswertz mswertz merged commit 5ae0013 into master Oct 17, 2024
1 check was pending
@mswertz mswertz deleted the fix/unknow_resource_types branch October 17, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some types are shown incorrectly on catalogue startpage as 'resources'
3 participants