-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(catalogue): model update to 5.2 #4345
Conversation
can you add the changes to the pr description , its hard to make out from the long csv strings in the change |
I was not done yet with this PR, it is a draft. |
waiting to merge until we can also migrate the data on acc to 5.1. (migrations are written, but need time to run them) |
@@ -8,5 +8,6 @@ dependencies { | |||
task generateTypes(type: JavaExec) { | |||
group = 'application' | |||
classpath = sourceSets.main.runtimeClasspath | |||
workingDir = rootProject.projectDir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do ? , why is it part of this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was necessary to generate the types (there was a bug created in the previous refactoring of the generateTypes task). This ensures the path is interpreted relatively to the root of the molgenis-emx2 repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also updated docs of nuxt3-ssr to explain how to run that task routinely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not encounter this issue while generating the ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably used another command than I did. What command do you use? because then we should add that maybe to the docs? Unless you also see this as an improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generateTypes --args... , strange but guess this fine , maybe my intelij had that task cached at the old location
…nclusion/exclusion criteria subpopulations
Think the 'Version' needs to be updated, for the dm script to know when to run , and when checking compatibility (manually ) |
Quality Gate passedIssues Measures |
What are the main changes you did:
how to test:
todo: