-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RDF): Email/UUID should now be an IRI instead of String (+ code maintenance for easier implementation) #4323
Draft
svandenhoek
wants to merge
30
commits into
master
Choose a base branch
from
feat/improve_rdf_api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y needed castings.
Quality Gate passedIssues Measures |
svandenhoek
changed the title
feat(RDF): Email should now be an IRI instead of String (+ code maintenance for easier implementation)
feat(RDF): Email/UUID should now be an IRI instead of String (+ code maintenance for easier implementation)
Oct 10, 2024
All tests should work once #4378 is merged and included in this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
Enum
CoreDatatype
retrieval &formatValue(row, column)
moved to a class dedicated forColumnType
-specific behaviour.Value
.CoreDataType
with different cell data retrieval without needing the 2-layer approach currently implemented throughformatValue()
(first layer differentiates references/FILE/others & second layer for others defines 1 basic approach per CoreDataType)SKIP
internal type to allow for specificColumnType
values to always return an emtpySet
rowsToRdf()
split into separate functions for ontologies/dataTableType
.TableType
check was done for eachRow
instead of for eachTable
.ColumnType
ColumnType
is removedColumnType
is added without updating the RDF API for it.urn:uuid:
IRIs instead of literalsColumnType.FILE
not being present in RDF output (+ updated to show correct path)ontologyTermURI
instead #4222how to test:
./gradlew run
curl http://localhost:8080/dcat/api/rdf > ~/Desktop/output_old.ttl
./gradlew run
curl http://localhost:8080/dcat/api/rdf > ~/Desktop/output_new.ttl
rdfdiff output_new.ttl output_old.ttl TTL TTL
Output should look like this (only unequal in regards to changes made to email):
Turtle output should now look something like this:
todo: