Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/basic theme #1323

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Conversation

billyquith
Copy link
Contributor

Modified the basic theme. Looks a little easier on the eye IMHO. Could do with another couple of passes to make the whole looks consistent.

image

billyquith and others added 2 commits December 17, 2022 23:18
@RogerHaase RogerHaase merged commit 258d897 into moinwiki:master Dec 19, 2022
@RogerHaase
Copy link
Member

Thanks for helping!

I like your changes. Only wish is the text on the sidebar (Site Navigation, etc) should have more contrast.

@billyquith
Copy link
Contributor Author

Thanks! I started having a look at the Modernized theme as well. I think that is the default one.

I noticed only the simple one seems to use Bootstrap and Bootstrap is not used in the default theme. Is the intention that BS should only be used as an extension, and will not be used in the common themes?

@RogerHaase
Copy link
Member

Topside is the default theme on moin2, Modernized is default on moin1.x.

Long ago the Modernized theme was using Stylus. I removed the Stylus code ~2020-08-06 after the implementation of CSS variables.

I never was a Bootstrap fan, and wasted much time chasing Stylus bugs. My main complaint is the size of the resulting CSS files: 134k for the basic theme.css; 9k for modernized; 7k for topside. iirc the reason we are using Bootstrap 3.1.1 is because many of the variable names changed in 4.0.

My preference is to limit use of Bootstrap to the Basic theme and enhance the use of CSS Variables for the other themes. But if you have a strong argument for use of Bootstrap, let's hear it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants