Skip to content

Commit

Permalink
Fixing layered jar problem
Browse files Browse the repository at this point in the history
This problem make it fails to build docker images for all the microservices.
  • Loading branch information
mohamed-taman committed Apr 6, 2020
1 parent b05ef3b commit 16e7118
Show file tree
Hide file tree
Showing 11 changed files with 47 additions and 14 deletions.
2 changes: 1 addition & 1 deletion product-composite-service/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ WORKDIR /home/taman/application
# Copy all layers from builder stage to current image
COPY --from=builder temp/dependencies/ ./
COPY --from=builder temp/snapshot-dependencies/ ./
COPY --from=builder temp/resources/ ./
COPY --from=builder temp/spring-boot-loader/ ./
COPY --from=builder temp/application/ ./

# Expose current application to port 8080
Expand Down
1 change: 1 addition & 0 deletions product-composite-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<version>0.0.1-SNAPSHOT</version>
<name>Product Composite Service</name>
<description>Product Composite Service Spring Boot based project</description>
<packaging>jar</packaging>

<properties>
<skip.dockerization>false</skip.dockerization>
Expand Down
2 changes: 1 addition & 1 deletion product-service/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ WORKDIR /home/taman/application
# Copy all layers from builder stage to current image
COPY --from=builder temp/dependencies/ ./
COPY --from=builder temp/snapshot-dependencies/ ./
COPY --from=builder temp/resources/ ./
COPY --from=builder temp/spring-boot-loader/ ./
COPY --from=builder temp/application/ ./

# Expose current application to port 8080
Expand Down
1 change: 1 addition & 0 deletions product-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<version>0.0.1-SNAPSHOT</version>
<name>Product Service</name>
<description>Product Service Spring Boot based project</description>
<packaging>jar</packaging>

<properties>
<skip.dockerization>false</skip.dockerization>
Expand Down
2 changes: 1 addition & 1 deletion recommendation-service/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ WORKDIR /home/taman/application
# Copy all layers from builder stage to current image
COPY --from=builder temp/dependencies/ ./
COPY --from=builder temp/snapshot-dependencies/ ./
COPY --from=builder temp/resources/ ./
COPY --from=builder temp/spring-boot-loader/ ./
COPY --from=builder temp/application/ ./

# Expose current application to port 8080
Expand Down
1 change: 1 addition & 0 deletions recommendation-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<version>0.0.1-SNAPSHOT</version>
<name>Recommendation Service</name>
<description>Recommendation Service Spring Boot based project</description>
<packaging>jar</packaging>

<properties>
<skip.dockerization>false</skip.dockerization>
Expand Down
2 changes: 1 addition & 1 deletion review-service/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ WORKDIR /home/taman/application
# Copy all layers from builder stage to current image
COPY --from=builder temp/dependencies/ ./
COPY --from=builder temp/snapshot-dependencies/ ./
COPY --from=builder temp/resources/ ./
COPY --from=builder temp/spring-boot-loader/ ./
COPY --from=builder temp/application/ ./

# Expose current application to port 8080
Expand Down
1 change: 1 addition & 0 deletions review-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<version>0.0.1-SNAPSHOT</version>
<name>Review Service</name>
<description>Review Service Spring Boot based project</description>
<packaging>jar</packaging>

<properties>
<skip.dockerization>false</skip.dockerization>
Expand Down
22 changes: 18 additions & 4 deletions store-api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,16 @@
<groupId>com.siriusxi.ms.store</groupId>
<artifactId>store-api</artifactId>
<version>1.0-SNAPSHOT</version>
<packaging>jar</packaging>

<name>Springy Store APIs</name>
<description>Project that define all Springy Store DTOs and REST APIs contracts</description>
<packaging>jar</packaging>

<properties>
<java.version>14</java.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<!-- Libraries versions -->
<spring.boot.dependencies.version>2.3.0.M3</spring.boot.dependencies.version>
<spring.boot.dependencies.version>2.3.0.M4</spring.boot.dependencies.version>
<maven.compiler.plugin.version>3.8.1</maven.compiler.plugin.version>
<maven.surefire.plugin.version>3.0.0-M4</maven.surefire.plugin.version>
<maven.failsafe.plugin.version>3.0.0-M4</maven.failsafe.plugin.version>
Expand Down Expand Up @@ -80,6 +79,21 @@
</configuration>
</plugin>
</plugins>

</build>

<repositories>
<repository>
<id>spring-milestones</id>
<name>Spring Milestones</name>
<url>https://repo.spring.io/milestone</url>
</repository>
</repositories>

<pluginRepositories>
<pluginRepository>
<id>spring-milestones</id>
<name>Spring Milestones</name>
<url>https://repo.spring.io/milestone</url>
</pluginRepository>
</pluginRepositories>
</project>
6 changes: 3 additions & 3 deletions store-chassis/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
<groupId>com.siriusxi.ms.store</groupId>
<artifactId>store-chassis</artifactId>
<version>0.0.1-SNAPSHOT</version>
<packaging>pom</packaging>
<name>Springy Store Chassis</name>
<description>Parent pom project for Springy μServices</description>
<packaging>pom</packaging>

<modules>
<module>../product-composite-service</module>
Expand All @@ -35,7 +35,7 @@
<dockerfile-maven-version>1.4.13</dockerfile-maven-version>

<!-- Custom properties -->
<maintainer.name>Mohamed Taman</maintainer.name>
<maintainer.name>"Mohamed Taman"</maintainer.name>
<maintainer.email>[email protected]</maintainer.email>
<docker.repo.image.prefix>siriusxi</docker.repo.image.prefix>
<docker.image.default.tag>latest</docker.image.default.tag>
Expand Down Expand Up @@ -191,7 +191,7 @@
<JAR_FILE>target/${project.build.finalName}.jar</JAR_FILE>
<IMAGE_VERSION>${project.version}</IMAGE_VERSION>
<IMAGE_NAME>${project.name}</IMAGE_NAME>
<MAINTAINER>"${maintainer.name} (${maintainer.email})"</MAINTAINER>
<MAINTAINER>${maintainer.name} (${maintainer.email})</MAINTAINER>
</buildArgs>
</configuration>
</plugin>
Expand Down
21 changes: 18 additions & 3 deletions store-utils/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,16 @@
<groupId>com.siriusxi.ms.store</groupId>
<artifactId>store-utils</artifactId>
<version>1.0-SNAPSHOT</version>
<packaging>jar</packaging>

<name>Springy Store Utils</name>
<description>Project that define all Springy Store shared functionality</description>
<packaging>jar</packaging>

<properties>
<java.version>14</java.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<!-- Libraries versions -->
<spring.boot.dependencies.version>2.3.0.M3</spring.boot.dependencies.version>
<spring.boot.dependencies.version>2.3.0.M4</spring.boot.dependencies.version>
<maven.compiler.plugin.version>3.8.1</maven.compiler.plugin.version>
<maven.surefire.plugin.version>3.0.0-M4</maven.surefire.plugin.version>
<maven.failsafe.plugin.version>3.0.0-M4</maven.failsafe.plugin.version>
Expand Down Expand Up @@ -95,4 +94,20 @@
</plugins>
</build>

<repositories>
<repository>
<id>spring-milestones</id>
<name>Spring Milestones</name>
<url>https://repo.spring.io/milestone</url>
</repository>
</repositories>

<pluginRepositories>
<pluginRepository>
<id>spring-milestones</id>
<name>Spring Milestones</name>
<url>https://repo.spring.io/milestone</url>
</pluginRepository>
</pluginRepositories>

</project>

0 comments on commit 16e7118

Please sign in to comment.