Skip to content

Conversation

@jenswittmann
Copy link
Contributor

What does it do?

This fixes an issue that occurred when sending a user a link to choose or reset their password.

Why is it needed?

The following error occurs when trying to use both features:

Error: Call to a member function reset() on null

/MODX/site/core/src/Revolution/modUser.php:961
 SecurityLoginManagerController->handleForgotLogin() in /MODX/site/manager/controllers/default/security/login.class.php:366
 SecurityLoginManagerController->handlePost() in /MODX/site/manager/controllers/default/security/login.class.php:60
 SecurityLoginManagerController->process(Array ( [username_reset] => ***@***.de [forgotlogin] => 1 ) ) in /MODX/site/core/src/Revolution/modManagerController.php:180
 MODX\Revolution\modManagerController->render() in /MODX/site/core/src/Revolution/modManagerResponse.php:114
 MODX\Revolution\modManagerResponse->outputContent(Array ( ) ) in /MODX/site/core/src/Revolution/modManagerRequest.php:173
 MODX\Revolution\modManagerRequest->prepareResponse() in /MODX/site/core/src/Revolution/modManagerRequest.php:143
 MODX\Revolution\modManagerRequest->handleRequest() in /MODX/site/manager/index.php:60

MODX 3.1.2
PHP 8.3.25

Copy link
Member

@opengeek opengeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@opengeek opengeek added the bug The issue in the code or project, which should be addressed. label Oct 21, 2025
@opengeek opengeek added this to the v3.2.0 milestone Oct 21, 2025
@opengeek opengeek added area-core pr/ready-for-merging Pull request reviewed and tested and ready for merging. cla-signed CLA confirmed for contributors to this PR. labels Oct 21, 2025
@opengeek opengeek merged commit e44827e into modxcms:3.x Oct 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-core bug The issue in the code or project, which should be addressed. cla-signed CLA confirmed for contributors to this PR. pr/ready-for-merging Pull request reviewed and tested and ready for merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants