Skip to content

Conversation

@ScriptedAlchemy
Copy link
Member

Per-package rslib bundleless migration for runtime.

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026

⚠️ No Changeset found

Latest commit: 98317e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98317e719d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 24 to 27
"import": {
"types": "./dist/index.d.ts",
"default": "./dist/index.esm.js"
"default": "./dist/index.js"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use .mjs for ESM entrypoints

Rslib’s ESM output defaults to .mjs in this repo (see the existing rslib-built package packages/modernjs which exports dist/esm/*.mjs), but the runtime package now points all ESM entrypoints to .js (e.g., ./dist/index.js). If rslib keeps emitting .mjs here as well, ESM consumers will hit MODULE_NOT_FOUND at runtime because the files referenced in module/exports.import don’t exist. Consider switching these ESM paths to .mjs (or explicitly configuring rslib to emit .js).

Useful? React with 👍 / 👎.

@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for module-federation-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 98317e7
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/69800902286d8d0008ec48c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants