Repository navigation
Conversation
Collaborator
|
hey @ravioli67, thanks for this! a few things need fixing before the build can pass:
To make it easier to know what's ready for review I'm closing PRs that aren't quite ready, please reopen when you've had a chance to update this 🙂 |
Author
|
Thank you for the feedback. I have updated my PR here: #414 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
recipe.yamlfile specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.0(for new packages, or if the version changed).I created a package called Mojo2Wasm, you can check it out here - https://github.com/ravioli67/mojo2wasm
This package's purpose is to bridge the gap between Mojo and Web Assembly and make a compiler to do so.