Skip to content

Added Mojo2Wasm as a package inside the recipes folder. - #402

Closed
ravioli67 wants to merge 4 commits into
modular:mainfrom
ravioli67:main
Closed

ravioli67 wants to merge 4 commits into
modular:mainfrom
ravioli67:main

Conversation

@ravioli67

Copy link
Copy Markdown

Checklist

  • My recipe.yaml file specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.
  • License file is packaged (see here for an example).
  • Set the build number to 0 (for new packages, or if the version changed).
  • Bumped the build number (if the version is unchanged).

I created a package called Mojo2Wasm, you can check it out here - https://github.com/ravioli67/mojo2wasm

This package's purpose is to bridge the gap between Mojo and Web Assembly and make a compiler to do so.

@alisterburt

Copy link
Copy Markdown
Collaborator

hey @ravioli67, thanks for this! a few things need fixing before the build can pass:

  • the recipe fetches tag v0.1.1 but the repo doesn't have any tags yet, so the source can't be fetched. You'll need to push the tag, or pin a commit with rev: instead
  • license_file: LICENSE needs to be LICENSE.md to match your repo
  • mojo_version: "=0.26.1" is quite old, most recipes are now on =1.1.0

To make it easier to know what's ready for review I'm closing PRs that aren't quite ready, please reopen when you've had a chance to update this 🙂

@ravioli67

Copy link
Copy Markdown
Author

Thank you for the feedback. I have updated my PR here: #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants