Skip to content

feat minimum character requirement for thread creation. #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 17, 2025
Merged

feat minimum character requirement for thread creation. #3380

merged 7 commits into from
Jul 17, 2025

Conversation

lorenzo132
Copy link
Member

change:

  • Minimum character requirement for creating new threads
  • Customizable error messages when users don't meet the requirement

new config options:

  • thread_min_characters - Set minimum characters required (default: 0)
  • thread_min_characters_title - Customize error embed title
  • thread_min_characters_response - Customize error embed description
  • thread_min_characters_footer - Customize error embed footer

lorenzo132 added 5 commits July 5, 2025 11:54
@lorenzo132
feat: thread_min_characters config.
c5c3e7c 
Added
- Config option `thread_min_characters` to require a minimum number of characters in the initial message to create a thread.
- Configurable error message options: `thread_min_characters_title`, `thread_min_characters_response`, and `thread_min_characters_footer`.
@lorenzo132
fix: syntax
746e115
@lorenzo132
Update config_help.json
c0ed9d2
@lorenzo132
fix: syntax
efc37fd
@lorenzo132
fix: embed error?
ab0071b
@lorenzo132 lorenzo132 mentioned this pull request Jul 5, 2025
Open
2 tasks
@lorenzo132
change: Exception ~> ValueError
fa65c47 
Changed:
- Only catch ValueError (instead of all exceptions) when parsing thread_min_characters config as an integer.
Taaku18
Taaku18 previously approved these changes Jul 16, 2025
View reviewed changes
@Taaku18 Taaku18 requested a review from Copilot July 17, 2025 21:16
Copilot
Copilot AI reviewed Jul 17, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Taaku18 Taaku18 merged commit 41b3db6 into modmail-dev:development Jul 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Taaku18 Taaku18 Taaku18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzo132 @Taaku18