Merge pull request #2813 from talentlessguy/bump-chokidar-v4

Bump chokidar v4
modernweb-dev · Sep 26, 2024 · 2204e25 · 2204e25
2 parents 12a5d31 + 8b98279
commit 2204e25
Show file tree

Hide file tree

Showing 5 changed files with 68 additions and 6 deletions.
diff --git a/.changeset/giant-games-count.md b/.changeset/giant-games-count.md
@@ -0,0 +1,6 @@
+---
+'@web/test-runner-core': patch
+'@web/dev-server-core': patch
+---
+
+bump chokidar to v4
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/dev-server-core/package.json b/packages/dev-server-core/package.json
@@ -61,7 +61,7 @@
     "@types/koa": "^2.11.6",
     "@types/ws": "^7.4.0",
     "@web/parse5-utils": "^2.1.0",
-    "chokidar": "^3.4.3",
+    "chokidar": "^4.0.1",
     "clone": "^2.1.2",
     "es-module-lexer": "^1.0.0",
     "get-stream": "^6.0.0",

diff --git a/packages/dev-server-core/src/server/DevServerCoreConfig.ts b/packages/dev-server-core/src/server/DevServerCoreConfig.ts
@@ -1,7 +1,7 @@
 import { Middleware } from 'koa';
 import { Plugin } from '../plugins/Plugin';
 import { Server } from 'net';
-import chokidar from 'chokidar';
+import type { ChokidarOptions } from 'chokidar';
 
 export type MimeTypeMappings = Record<string, string>;
 
@@ -72,5 +72,5 @@ export interface DevServerCoreConfig {
   /**
    * Additional options you want to provide to chokidar file watcher
    */
-  chokidarOptions?: chokidar.WatchOptions;
+  chokidarOptions?: ChokidarOptions;
 }
diff --git a/packages/test-runner-core/package.json b/packages/test-runner-core/package.json
@@ -61,7 +61,7 @@
     "@types/istanbul-reports": "^3.0.0",
     "@web/browser-logs": "^0.4.0",
     "@web/dev-server-core": "^0.7.2",
-    "chokidar": "^3.4.3",
+    "chokidar": "^4.0.1",
     "cli-cursor": "^3.1.0",
     "co-body": "^6.1.0",
     "convert-source-map": "^2.0.0",