fix(util): math util 함수의 반복문을 for...of 문으로 수정 (#304)

* fix: math util 함수의 반복문을 for...of 문으로 수정 * Create strange-mayflies-provide.md --------- Co-authored-by: Gromit (전민재) <[email protected]>
modern-agile-team · Jul 5, 2024 · eba8634 · eba8634
1 parent cf117da
commit eba8634
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/strange-mayflies-provide.md b/.changeset/strange-mayflies-provide.md
@@ -0,0 +1,5 @@
+---
+"@modern-kit/utils": patch
+---
+
+fix(util): math util 함수의 반복문을 for...of 문으로 수정 - @Collection50
diff --git a/packages/utils/src/math/max/index.ts b/packages/utils/src/math/max/index.ts
@@ -13,14 +13,14 @@ export function max<T>(
   let maxValue = Number.MIN_SAFE_INTEGER;
   let maxItem = arr[0];
 
-  arr.forEach((item) => {
+  for (const item of arr) {
     const value = iteratee(item);
 
     if (value > maxValue) {
       maxItem = item;
       maxValue = value;
     }
-  });
+  }
 
   return maxItem;
 }
diff --git a/packages/utils/src/math/min/index.ts b/packages/utils/src/math/min/index.ts
@@ -13,14 +13,14 @@ export function min<T>(
   let minValue = Number.MAX_SAFE_INTEGER;
   let minItem = arr[0];
 
-  arr.forEach((item) => {
+  for (const item of arr) {
     const value = iteratee(item);
 
     if (value < minValue) {
       minItem = item;
       minValue = value;
     }
-  });
+  }
 
   return minItem;
 }