revert: min, max 기존 코드로 복구 및 테스트 코드 추가

modern-agile-team · Jun 25, 2024 · 0666aba · 0666aba
1 parent 4c3c0e0
commit 0666aba
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 11 deletions.
diff --git a/packages/utils/src/math/max/index.ts b/packages/utils/src/math/max/index.ts
@@ -10,17 +10,17 @@ export function max<T>(
   arr: T[] | readonly T[],
   iteratee: (item: T) => number = identity as (item: T) => number
 ) {
-  let maxValue = iteratee(arr[0]);
+  let maxValue = Number.MIN_SAFE_INTEGER;
   let maxItem = arr[0];
 
-  for (let i = 1; i < arr.length; i++) {
-    const value = iteratee(arr[i]);
+  arr.forEach((item) => {
+    const value = iteratee(item);
 
     if (value > maxValue) {
-      maxItem = arr[i];
+      maxItem = item;
       maxValue = value;
     }
-  }
+  });
 
   return maxItem;
 }
diff --git a/packages/utils/src/math/max/max.spec.ts b/packages/utils/src/math/max/max.spec.ts
@@ -29,10 +29,19 @@ describe('max', () => {
     expect(result).toBe('banana');
   });
 
-  it('should handle empty array', () => {
+  it('should handle empty array(default)', () => {
     const arr: number[] = [];
     const result = max(arr);
 
     expect(result).toBeUndefined();
   });
+
+  it('should handle empty array(iteratee)', () => {
+    const arr: {
+      value: number;
+    }[] = [];
+    const result = max(arr, (item) => item.value);
+
+    expect(result).toBeUndefined();
+  });
 });
diff --git a/packages/utils/src/math/min/index.ts b/packages/utils/src/math/min/index.ts
@@ -10,17 +10,17 @@ export function min<T>(
   arr: T[] | readonly T[],
   iteratee: (item: T) => number = identity as (item: T) => number
 ) {
-  let minValue = iteratee(arr[0]);
+  let minValue = Number.MAX_SAFE_INTEGER;
   let minItem = arr[0];
 
-  for (let i = 1; i < arr.length; i++) {
-    const value = iteratee(arr[i]);
+  arr.forEach((item) => {
+    const value = iteratee(item);
 
     if (value < minValue) {
-      minItem = arr[i];
+      minItem = item;
       minValue = value;
     }
-  }
+  });
 
   return minItem;
 }
diff --git a/packages/utils/src/math/min/min.spec.ts b/packages/utils/src/math/min/min.spec.ts
@@ -35,4 +35,13 @@ describe('min', () => {
 
     expect(result).toBeUndefined();
   });
+
+  it('should handle empty array(iteratee)', () => {
+    const arr: {
+      value: number;
+    }[] = [];
+    const result = min(arr, (item) => item.value);
+
+    expect(result).toBeUndefined();
+  });
 });