fix(utils): excludeElements 개선

modern-agile-team · Jul 5, 2024 · 03dbe70 · 03dbe70
1 parent fc6eb4d
commit 03dbe70
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/docs/docs/utils/array/excludeElements.md b/docs/docs/utils/array/excludeElements.md
@@ -12,10 +12,10 @@
 
 ## Interface
 ```ts title="typescript"
-const excludeElements: <T, U = T>(
+const excludeElements: <T, U>(
   array: T[] | readonly T[],
   excludeArray: T[] | readonly T[],
-  iteratee?: (item: T) => U
+  iteratee?: ((item: T) => U) | undefined
 ) => T[];
 ```
 

diff --git a/packages/utils/src/array/excludeElements/index.ts b/packages/utils/src/array/excludeElements/index.ts
@@ -1,11 +1,16 @@
-import { identity } from '../../common';
-
-export const excludeElements = <T, U = T>(
+export const excludeElements = <T, U>(
   array: T[] | readonly T[],
   excludeArray: T[] | readonly T[],
-  iteratee: (item: T) => U = identity as (item: T) => U
+  iteratee?: (item: T) => U
 ) => {
-  const excludeSet = new Set(excludeArray.map(iteratee));
+  const excludeArrayToUse = iteratee
+    ? excludeArray.map(iteratee)
+    : excludeArray;
+
+  const exclusionSet = new Set<T | U>(excludeArrayToUse);
 
-  return array.filter((element) => !excludeSet.has(iteratee(element)));
+  if (iteratee) {
+    return array.filter((element) => !exclusionSet.has(iteratee(element)));
+  }
+  return array.filter((element) => !exclusionSet.has(element));
 };