-
Notifications
You must be signed in to change notification settings - Fork 14
feat: update more graders including multimodal graders #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jc200808, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a series of updates across multiple grader classes, enhancing robustness and consistency. Key changes include ensuring default templates are correctly applied in grader initializers, removing redundant code, and improving docstring examples to be runnable. The prompt definitions in multimodal graders have also been refactored for better readability.
Overall, the changes are positive and improve the codebase. I've pointed out a minor but important correction in two of the multimodal graders where an incorrect parameter name was used in the super().__init__ call. Addressing this will ensure the code is not just functionally correct but also clear and maintainable.
| """ | ||
| super().__init__( | ||
| name="image_coherence", | ||
| grader_mode=GraderMode.POINTWISE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there's a small typo in the parameter name. The LLMGrader's __init__ method expects the parameter mode, but grader_mode is used here. While this might work due to **kwargs handling, it's better to use the correct parameter name for clarity and to avoid potential issues.
| grader_mode=GraderMode.POINTWISE, | |
| mode=GraderMode.POINTWISE, |
| """ | ||
| super().__init__( | ||
| name="image_helpfulness", | ||
| grader_mode=GraderMode.POINTWISE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to another file in this PR, there's a small typo here. The LLMGrader's __init__ method expects the parameter mode, but grader_mode is used. Using the correct parameter name mode will make the code more robust and clear.
| grader_mode=GraderMode.POINTWISE, | |
| mode=GraderMode.POINTWISE, |
ployts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OpenJudge Version
[The version of OpenJudge you are working on, e.g.
import openjudge; print(openjudge.__version__)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
pre-commit run --all-filescommand