Skip to content

Conversation

@aftersnow
Copy link
Contributor

Clarified descriptions for application/vnd.cncf.model.weight.v1.tar+gzip and application/vnd.cncf.model.weight.v1.tar+zstd to specify that they contain the model weight file, ensuring consistency in the documentation.

Clarified descriptions for `application/vnd.cncf.model.weight.v1.tar+gzip` and `application/vnd.cncf.model.weight.v1.tar+zstd` to specify that they contain the model weight file, ensuring consistency in the documentation.

Signed-off-by: Zhao Chen <[email protected]>
@gemini-code-assist
Copy link

Summary of Changes

Hello @aftersnow, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the official specification by clarifying the purpose of specific model weight media types. The changes aim to enhance documentation accuracy and consistency, ensuring that the descriptions precisely reflect the content of the archived model weight files.

Highlights

  • Documentation Clarity: Updated the descriptions for application/vnd.cncf.model.weight.v1.tar+gzip and application/vnd.cncf.model.weight.v1.tar+zstd media types in docs/spec.md.
  • Specification Consistency: Ensured that the descriptions for compressed model weight media types (+gzip, +zstd) accurately reflect that they contain the model weight file, aligning with the description for the uncompressed .tar type.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the descriptions for the application/vnd.cncf.model.weight.v1.tar+gzip and application/vnd.cncf.model.weight.v1.tar+zstd media types to state that they contain model weight files, not configuration files. This is a good clarification. I've added a couple of suggestions to further improve consistency in the specification by adding guidance on handling multiple weight files, similar to what's already present for the uncompressed tar media type.

@aftersnow aftersnow added the documentation Improvements or additions to documentation label Nov 7, 2025
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi enabled auto-merge November 10, 2025 20:52
@imeoer
Copy link

imeoer commented Nov 12, 2025

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 778ed6d into main Nov 12, 2025
6 of 7 checks passed
@gaius-qi gaius-qi deleted the fix-mediatype-doc branch November 12, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants