-
Notifications
You must be signed in to change notification settings - Fork 20
fix: update specification for model weight media types #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Clarified descriptions for `application/vnd.cncf.model.weight.v1.tar+gzip` and `application/vnd.cncf.model.weight.v1.tar+zstd` to specify that they contain the model weight file, ensuring consistency in the documentation. Signed-off-by: Zhao Chen <[email protected]>
Summary of ChangesHello @aftersnow, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the official specification by clarifying the purpose of specific model weight media types. The changes aim to enhance documentation accuracy and consistency, ensuring that the descriptions precisely reflect the content of the archived model weight files. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the descriptions for the application/vnd.cncf.model.weight.v1.tar+gzip and application/vnd.cncf.model.weight.v1.tar+zstd media types to state that they contain model weight files, not configuration files. This is a good clarification. I've added a couple of suggestions to further improve consistency in the specification by adding guidance on handling multiple weight files, similar to what's already present for the uncompressed tar media type.
gaius-qi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
LGTM |
chlins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Clarified descriptions for
application/vnd.cncf.model.weight.v1.tar+gzipandapplication/vnd.cncf.model.weight.v1.tar+zstdto specify that they contain the model weight file, ensuring consistency in the documentation.