-
Notifications
You must be signed in to change notification settings - Fork 44
Gather all specification of interval() at first tick under 'interval' #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Gather all specification of interval() at first tick under 'interval' #3761
Conversation
Since this PR is probably getting more attention than the issue, I'll repeat the question in the issue here: What is or when the controller is switched on supposed to mean? As this is also related to the specification of the first clock tick, perhaps we could also address it in this PR? |
I don't know. Just thinking in general it could either be that one for some reason consider generating a controller from the model, so it is similar but using different words to indicate that it isn't "a simulation" but an actual system, or it could a controller inside a state machine.
The incomplete part is that it says: "The clock starts at the start of the simulation tstart or when the controller is switched on. At the start of the simulation, previous(intervalCounter) = intervalCounter.start and the clocks ticks the first time." but it doesn't say what "previous(intervalCounter)" is when the controller is switched on. If we assume "controller is switched on" is the same as "start of the simulation" it's just a bit confusing, but otherwise it is just unclear. So, my conclusion is that it likely is just a special case "start of the simulation" and it is best to remove it. |
chapters/synchronous.tex
Outdated
\item For an event clock the additional \lstinline!startInterval! argument to the event clock constructor is returned. | ||
\end{enumerate} | ||
\begin{itemize} | ||
\item For a rational interval clock (\cref{modelica:clock-rational}): \lstinline!previous($\mathit{intervalCounter}$)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\item For a rational interval clock (\cref{modelica:clock-rational}): \lstinline!previous($\mathit{intervalCounter}$)! | |
\item For a rational interval clock (\cref{modelica:clock-rational}): \lstinline!previous($\mathit{intervalCounter}$)/resolution! |
It was missing before, but when we add it, then it must be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, but with proper formatting. OK?
Per request from Hans.
Fixes #3751.