feat!: relax tool result structuredContent type (SEP-2106)#919
Open
DaleSeo wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
T-test
DaleSeo
changed the title
DaleSeo
force-pushed
the
fix/tool-result-content-structured-value
branch
from
97d6a3d to
4dcb918
Compare
alexhancock
approved these changes
Jun 26, 2026
|
|
||
| #[tokio::test] | ||
| async fn test_tool_result_content_with_primitive_structured_content() -> Result<()> { | ||
| let structured = serde_json::json!(42); |
Contributor
There was a problem hiding this comment.
Worth one that loops through all the possible primitive types (string, number, boolean, null) and does the same test? This way it would catch if anyone changes it in some way that drops support for something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This was discovered while reviewing PR #895. Besides
CallToolResult,ToolResultContentshould also be typed with its structured content asOption<Value>to accommodate any JSON value.How Has This Been Tested?
Added tests
Breaking Changes
Yes. The public field
ToolResultContent.structured_contentchanges type fromOption<JsonObject>toOption<Value>.The green SemVer Check is a false negative due to known upstream gap: obi1kenobi/cargo-semver-checks#148
Types of changes
Checklist