Validate protocol_version value
#80
Open
+22
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation and Context Currently, MCP supports the following three protocol versions: "2025-06-18", "2025-03-26", and "2024-11-05". https://modelcontextprotocol.io/introduction As shown in the changes to `test/mcp/configuration_test.rb`, the `protocol_version` value is not currently being validated, which allows unexpected `protocol_version` values to be accepted. This PR ensures that only supported protocol versions are accepted. ## How Has This Been Tested? Existing tests have been updated and new tests have been added. ## Breaking Changes None. If it becomes an issue, it means a value that was not originally intended has been used. ## Additional context While one possible approach might be to fall back to a default protocol version when an invalid `protocol_version` value is provided, this PR opts to reject invalid `protocol_version` values explicitly. The reasoning is that encouraging users to provide intentional, valid input is preferable to silently falling back to a default, which could lead to unexpected behavior.
atesgoral
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, MCP supports the following three protocol versions: "2025-06-18", "2025-03-26", and "2024-11-05".
https://modelcontextprotocol.io/introduction
As shown in the changes to
test/mcp/configuration_test.rb, theprotocol_versionvalue is not currently being validated, which allows unexpectedprotocol_versionvalues to be accepted.This PR ensures that only supported protocol versions are accepted.
How Has This Been Tested?
Existing tests have been updated and new tests have been added.
Breaking Changes
None. If it becomes an issue, it means a value that was not originally intended has been used.
Types of changes
Checklist
Additional context
While one possible approach might be to fall back to a default protocol version when an invalid
protocol_versionvalue is provided, this PR opts to reject invalidprotocol_versionvalues explicitly. The reasoning is that encouraging users to provide intentional, valid input is preferable to silently falling back to a default, which could lead to unexpected behavior.