Remove shebang from example files#67
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom Jun 23, 2025
Merged
Conversation
Since the example files are not executable binaries, this PR removes the shebangs. This ensures that all examples are consistently executed via `ruby` command. It also removes the executable permission from `examples/stdio_server.rb` using `chmod 444`, bringing it in line with the other example files.
sambostock
approved these changes
Jun 23, 2025
Contributor
sambostock
left a comment
sambostock
left a comment
There was a problem hiding this comment.
Makes sense, with one nit
Comment on lines
11
to
+12
| ```bash | ||
| ruby examples/stdio_server.rb | ||
| $ ruby examples/stdio_server.rb |
Contributor
There was a problem hiding this comment.
If we're using prefixes before running commands, we should use the console language for the codeblock
```console
$ ruby examples/stdio_server.rb(Same for the other code blocks)
Member
Author
There was a problem hiding this comment.
Yeah, I think so too. That said, this repository uses bash, so a separate PR will likely change it to console.
9 tasks
topherbullock
pushed a commit
that referenced
this pull request
Jul 2, 2025
Follow-up to #67 (comment). This PR updates code blocks for command examples to use `console` as the language identifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Since the example files are not executable binaries, this PR removes the shebangs.
This ensures that all examples are consistently executed via
rubycommand. It also removes the executable permission fromexamples/stdio_server.rbusingchmod 444, bringing it in line with the other example files.Types of changes
Checklist
Additional context