[Doc] Add links to badges#52
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom Jun 9, 2025
Merged
Conversation
This PR adds links to the following two badges: 1. RubyGems badge: A link to the `mcp` gem will be added. The repository name is `ruby-sdk`, following the modelcontextprotocol org's naming convention. Since the repository name and the gem name are different, the link will help make it clear which gem it refers to. 2. MIT license badge: This will link to the MIT license file in the repository. NOTE: Separately from this PR, the copyright notice in the MIT license should probably be addressed. It currently says `Copyright (c) 2025 TODO: Write your name`, so the TODO should be resolved: https://github.com/modelcontextprotocol/ruby-sdk/blob/v0.1.0/LICENSE.txt#L3 Other language SDKs seem to list `Anthropic, PBC` as the copyright holder, though I would defer that decision to someone more knowledgeable.
atesgoral
approved these changes
Jun 9, 2025
Contributor
|
Created #53 for the copyright notice issue |
Member
Author
|
Thank you, Ates! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds links to the following two badges:
mcpgem will be added. The repository name isruby-sdk, following the modelcontextprotocol org's naming convention. Since the repository name and the gem name are different, the link will help make it clear which gem it refers to.NOTE: Separately from this PR, the copyright notice in the MIT license should probably be addressed. It currently says
Copyright (c) 2025 TODO: Write your name, so the TODO should be resolved: https://github.com/modelcontextprotocol/ruby-sdk/blob/v0.1.0/LICENSE.txt#L3Other language SDKs seem to list
Anthropic, PBCas the copyright holder, though I would defer that decision to someone more knowledgeable.Types of changes
Checklist