Skip to content

#552 #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

#552 #707

wants to merge 9 commits into from

Conversation

DanielAvdar
Copy link
Contributor

This pull request adds a new test to verify the fix for a Windows-specific process creation issue described in issue #552. The test ensures that the process creation function works without hanging.

Added test for Windows process creation:

  • tests/issues/test_552_windows_hang.py: Introduced a new test, test_windows_process_creation, to validate the functionality of _create_platform_compatible_process on Windows. The test uses a simple command (cmd /c echo Test successful) and sets a timeout to prevent hanging. It verifies that the process is created successfully and produces output.

@ihrpr ihrpr added this to the HPR milestone May 13, 2025
Refactored test to utilize `stdio_client` for more accurate simulation of the fixed behavior and added handling for proper initialization with `ClientSession`. Increased timeout to 10 seconds to prevent premature failures and ensured hanging issue is properly caught and reported.

Signed-off-by: DanielAvdar <[email protected]>
@DanielAvdar
Copy link
Contributor Author

DanielAvdar commented May 14, 2025

The test tests/issues/test_552_windows_hang.py is currently marked as xfail for hanging processes, which is the expected behavior. It will pass once the issue causing the hang is resolved.
@ihrpr

@DanielAvdar DanielAvdar marked this pull request as ready for review May 14, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants