Fix SSE server transport to support relative and absolute endpoints #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the endpoint URL handling in the SSE server transport to support both relative and absolute URLs. Some clients like Copilot Studio require absolute URLs. This change aligns with the TypeScript SDK's support for absolute endpoint URLs as in https://github.com/modelcontextprotocol/typescript-sdk/blob/main/src/server/sse.ts The PR: 1. Removes unnecessary URL quoting which would break absolute URLs 2. Adds comprehensive tests for both relative and absolute URL endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable absolute endpoint URLs in the SSE server transport (previously only relative URLs worked), matching the behavior of the TypeScript SDK.
What changed
Why it matters
Clients such as Copilot Studio require absolute URLs; this update restores compatibility.
Testing
All new and existing tests pass locally, including the new absolute-URL cases. Verified end-to-end in a sample app.
Breaking changes
None.