chore: include cli and ws extras in dev environment #1905
Conversation
RinZ27
force-pushed
the
fix/bump-starlette
branch
2 times, most recently
from
d48df76 to
0863e2d
Compare
pyproject.toml
Outdated
| "dirty-equals>=0.9.0", | ||
| "coverage[toml]>=7.13.1", | ||
| "pillow>=12.0", | ||
| "typer>=0.16.0", |
|
Dropping the constraints is not necessary. This is not a vulnerability here. |
RinZ27
force-pushed
the
fix/bump-starlette
branch
from
0863e2d to
b66941b
Compare
RinZ27
changed the title
|
I've updated the PR to address your feedback. Specifically, I've replaced the manual I've also reverted the |
pyproject.toml
Outdated
| "pyright>=1.1.400", | ||
| "pytest>=8.3.4", | ||
| "ruff>=0.8.5", | ||
| "trio>=0.26.2", | ||
| "pytest-flakefinder>=1.1.0", | ||
| "pytest-xdist>=3.6.1", | ||
| "pytest-examples>=0.0.14", | ||
| "pytest-pretty>=1.2.0", | ||
| "inline-snapshot>=0.23.0", | ||
| "dirty-equals>=0.9.0", | ||
| "coverage[toml]>=7.13.1", | ||
| "pillow>=12.0", | ||
| "mcp[cli,ws]", |
There was a problem hiding this comment.
Can you move it to the first, and add a note, please?
Something like # We add mcp[cli,ws] so uv sync considers the extras..
|
@Kludex I've moved |
RinZ27
force-pushed
the
fix/bump-starlette
branch
from
8ef7b94 to
0379ba0
Compare
pyproject.toml
Outdated
| "pyright\u003e=1.1.400", | ||
| "pytest\u003e=8.3.4", | ||
| "ruff\u003e=0.8.5", | ||
| "trio\u003e=0.26.2", | ||
| "pytest-flakefinder\u003e=1.1.0", | ||
| "pytest-xdist\u003e=3.6.1", | ||
| "pytest-examples\u003e=0.0.14", | ||
| "pytest-pretty\u003e=1.2.0", | ||
| "inline-snapshot\u003e=0.23.0", | ||
| "dirty-equals\u003e=0.9.0", | ||
| "coverage[toml]\u003e=7.13.1", | ||
| "pillow\u003e=12.0", |
RinZ27
force-pushed
the
fix/bump-starlette
branch
from
0379ba0 to
1420c68
Compare
|
Just noticed some weird Unicode sequences ( |
2 participants
I've updated the
devdependency group to reference the project's owncliandwsextras. This ensures that the test environment is complete for local development without duplicating package entries.Also, I've reverted the
starletteversion bump based on the feedback that the constraint change wasn't necessary in this context.Let me know if this revised approach looks good to you.