Change visibility of StdioTransport methods to protected #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvluoyue
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
lvluoyue
changed the title
|
How about decorating it or implementing a separate transport? which framework are you referring to? |
The framework I mentioned is webman, which encapsulates different event loops into a unified interface, such as Swoole, Swow, and Fiber. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I need to extend
StdioTransportbecause the framework I'm using has an event loop with stream read and write event listening capabilities, which can perfectly replacewhile (!feof($this->input)). However, some methods inStdioTransportare notprotected, preventing me from implementing the required logic.