Move samples deps to version catalog #128
Open
+52
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the dependencies of the samples to a single source - the root version catalog
Its a solution between a fully integregation of the samples (#119) into the project, while maintaining a single file for all dependencies.
With that, dependabot (see #121) is also able to update dependencies from the samples.
How Has This Been Tested?
I haven't tested the samples ❗
Because of the dependency bumps (might happen), it might be the case that they don't work anymore.
I just run
./gradlew helpin the root project and the samples to make sure that dependency resolution works correctly.Breaking Changes
No breaking changes for consumers of the library itself.
Types of changes
Checklist
Additional context