fix remove name when using @JsonTypeInfo(use = JsonTypeInfo.Id.DEDUCTION) #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull-request removes the name member from the @JsonSubTypes.Type annotations when using JsonTypeInfo.Id.DEDUCTION. With DEDUCTION, Jackson ignores the name entirely because it's inferring the type from the structure.
sdelamo
changed the title
tzolov
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
It is nice that Jackson can infers the subtype with no discriminator meta field.
As long as the ResourceContents have distinct, non-overlapping properties for Jackson to reliably deduce the correct type. It is the case for TextResourceContents, BlobResourceContents
tzolov
pushed a commit
that referenced
this pull request
Oct 6, 2025
This pull-request removes the name member from the @JsonSubTypes.Type annotations when using JsonTypeInfo.Id.DEDUCTION. With DEDUCTION, Jackson ignores the name entirely because it's inferring the type from the structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request removes the name member from the @JsonSubTypes.Type annotations when using JsonTypeInfo.Id.DEDUCTION.
With DEDUCTION, Jackson ignores the name entirely because it's inferring the type from the structure.
Motivation and Context
The incorrect usage of
namewas causing serialization issues downstream.How Has This Been Tested?
Existing tests in the project still pass
Breaking Changes
No
Types of changes
Checklist