Fix Streamable HTTP WebClient GET SSE handling #318
Merged
+75
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dariusz Jędrzejczyk <[email protected]>
chemicL
commented
Jun 16, 2025
| @@ -424,6 +444,20 @@ void testInitializeWithSamplingCapability() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| void testInitializeWithElicitationCapability() { | |||
There was a problem hiding this comment.
Added this when synchronizing between mcp/src/test and mcp-test/src/main (the files should have the same contents) but the elicitation was not synchronized properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebClient Streamable HTTP implementation was missing the incoming message handling on the SSE channel opened with
GETHTTP method. This caused sampling to not work when used against the typescript-sdk basedeverythingserverThe specification uses the word
SHOULDwhen talking about requests from the server to the client that they should use the same stream which is used for the related client request (tool call in this case) but apparently the typescript-sdk uses a different SSE connection to send the createMessage request. We should handle that properly.Also, this PR fixes a problematic
DELETEmethod handling in which the current session was replaced with an uninitialized one first before closing the existing session. That call would then extract the session id to sendDELETEfor, but it used the uninitialized one instaed of the one being closed. This PR fixes it too.