Skip to content

initalize logging after connection #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

antholeole
Copy link

@antholeole antholeole commented Jul 11, 2025

after a connection is established, send a setLoggingLevel request

#610

Motivation and Context

How Has This Been Tested?

manually, but this is a very small change. i could write unit if required

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Copy link
Member

@olaservo olaservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to add the setLoggingLevel to match the default selected level. I just had one comment. (And I think you have some linting errors that are failing the CI.)

Side note, I think the title of the issue you linked to this PR ("The MCP spec for logging requires a setLevel message before logs should be emitted ") doesn't seem accurate, since a server could still emit logs without this being set.

@olaservo olaservo added the waiting on submitter Waiting for the submitter to provide more info label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on submitter Waiting for the submitter to provide more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants