Skip to content

Conversation

appleboy
Copy link

  • Fix typo in "TroubleShooting" heading, changing it to "Troubleshooting"
  • Improve CLI usage instructions by formatting commands as code blocks and marking them with "bash"
  • Change "Start the Server" to a third-level heading for clarity
  • Add additional code examples for real-world client testing and interaction steps
  • Clarify and condense instructions for adding the tool to a popular MCP client

README.md Outdated
"context"
"log"
"os/exec"
"context"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change from tabs to spaces seems incorrect. Code code should be indented with tabs, and that is (or should be) the case for all other examples.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert the section.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@findleyr revert in c41f35c

@findleyr
Copy link
Contributor

The CI failure is confusing, sorry. I sent #568 to fix it.

We generate parts of our README, so you need to modify internal/readme/README.src.md, not README.md, and then run go generate ./.... Thanks.

- Fix typo in "TroubleShooting" heading, changing it to "Troubleshooting"
- Improve CLI usage instructions by formatting commands as code blocks and marking them with "bash"
- Change "Start the Server" to a third-level heading for clarity
- Add additional code examples for real-world client testing and interaction steps
- Clarify and condense instructions for adding the tool to a popular MCP client

Signed-off-by: appleboy <[email protected]>
- No changes to summarize; the diff is empty.

Signed-off-by: appleboy <[email protected]>
- Capitalize the "TroubleShooting" heading for consistency with title case formatting

Signed-off-by: appleboy <[email protected]>
@appleboy
Copy link
Author

The CI failure is confusing, sorry. I sent #568 to fix it.

We generate parts of our README, so you need to modify internal/readme/README.src.md, not README.md, and then run go generate ./.... Thanks.

See a6bb395

@findleyr
Copy link
Contributor

(need another reviewer as I resolved merge conflicts)

@appleboy
Copy link
Author

@findleyr Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants