Skip to content

async call handleNotify in notifySessions #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

async call handleNotify in notifySessions #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions mcp/shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,18 +346,23 @@ func notifySessions[S Session, P Params](sessions []S, method string, params P)
if sessions == nil {
return
}
// TODO: make this timeout configurable, or call handleNotify asynchronously.
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()

// TODO: there's a potential spec violation here, when the feature list
// changes before the session (client or server) is initialized.
for _, s := range sessions {
req := newRequest(s, params)
if err := handleNotify(ctx, method, req); err != nil {
// TODO(jba): surface this error better
log.Printf("calling %s: %v", method, err)
}
// Call handleNotify asynchronously to avoid blocking
go func(r Request) {
// Use a reasonable timeout to prevent goroutine leaks
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()

if err := handleNotify(ctx, method, r); err != nil {
// TODO(jba): surface this error better
log.Printf("notify session, calling %s fails, err: %v", method, err)
}
}(req)

}
}

Expand Down