IdleTracking uses lists instead of SortedSet #629
+26
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how
IdleTrackingBackgroundService
does bookkeeping for the idle sessions. Instead of using aSortedSet
that requires a lot of comparisons, it uses two lists for timestamps and sessions ids. Only if the limit is breached, sessions are sorted and picked up to be released. This removes allocations for theSortedSet,Node
and.ToArray()
and makes the bookkeeping less allocatey.Motivation and Context
Make
IdleTrackingBackgroundService
a bit faster and less allocating when performing session bookkeeping.How Has This Been Tested?
Locally, with the existing suite. If this PR is considered for merging and a component specific test is required I'm happy to provide one.
Breaking Changes
None.
Types of changes
Checklist