pkg/archive: un-skip tests on Windows V19H1 (1903) and up #48004
+0
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
platform/windows
status/2-code-review
area/testing
area/go-sdk
thaJeztah
force-pushed
the
pkg_archive_unskip_windows
branch
from
dedc4fe
to
6ff26e6
Compare
thaJeztah
changed the title
|
OK; that didn't work; still an issue indeed; I'll open an alternative PR to remove the kernel-version check, because we no longer run CI on those older versions |
…version check
TestChangesDirsEmpty and TestChangesDirsMutated fail on Windows V19H1 (1903)
and up, possibly due to changes in the kernel:
=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsEmpty (0.21s)
changes_test.go:261: Reported changes for identical dirs: [{\dirSymlink C}]
=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsMutated (0.14s)
changes_test.go:391: unexpected change "C \\dirSymlink" "\\dirnew"
commit 8f4b3b0 added a version-dependent
skip for those tests, but as we no longer run CI on versions before V19H1,
we can remove the kernel-version check, and skip it on Windows unconditionally.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This re-enables TestChangesDirsEmpty and TestChangesDirsMutated on current Windows versions. These tests were failing on Windows V19H1 (1903) and up, possibly due to changes in the kernel, and were skipped in commit 8f4b3b0; === FAIL: github.com/docker/docker/pkg/archive TestChangesDirsEmpty (0.21s) changes_test.go:261: Reported changes for identical dirs: [{\dirSymlink C}] === FAIL: github.com/docker/docker/pkg/archive TestChangesDirsMutated (0.14s) changes_test.go:391: unexpected change "C \\dirSymlink" "\\dirnew" This reverts commit 8f4b3b0. This reverts commit 3108165 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
pkg_archive_unskip_windows
branch
from
6ff26e6
to
dd15c30
Compare
thaJeztah
added
the
impact/go-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables TestChangesDirsEmpty and TestChangesDirsMutated on current Windows versions. These tests were failing on Windows V19H1 (1903) and up, possibly due to changes in the kernel, and were skipped in commit 8f4b3b0;
This reverts commit 8f4b3b0.
- A picture of a cute animal (not mandatory but encouraged)