Repository navigation
cache: fix content hash leak for removed records - #7264
Open
janwaleed09 wants to merge 1 commit into
Open
janwaleed09 wants to merge 1 commit into
janwaleed09 wants to merge 1 commit into
Conversation
Signed-off-by: Jan Mohr <jan.mohr.1@web.de>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7263
The content hash tree is saved in the background. If the record is removed before that, for example by
finalize(),SetExternalcreates_external/<id>again and nothing deletes it later.SetExternalchecks in the same transaction that the record still exists.init()removes_externalentries without a record, so data left by older versions is cleaned up.TestNoPersistenceAfterRecordRemovalfails without this change.TestExternalDatawrote external data without a record, so it now creates the record first.Also tested with the build pattern from #7263 on a dockerd built with this change:
_externalstays empty after a full prune, and old entries are removed on the first start.