Repository navigation
fix(solver): check for context canceled in ReleaseUnreferenced - #7236
jsternberg wants to merge 1 commit into
Conversation
|
Waiting to verify that the CI tests fail properly when the context is checked in the existing code and then I'll amend the commit with the fix. Found this while working on the sqlite cache backend since the sqlite version of |
d6d7917 to
9c05191
Compare
|
Coming back to this and after talking briefly with @tonistiigi I'm just going to submit the fix here and not bother with tests. Testing this behavior adds far too much code and overhead than is gained from the tests themselves. Since the call to |
9c05191 to
30b196c
Compare
The existing implementations do not check for the context being canceled when `ReleaseUnreferenced` is called which has caused a bug in how the controller invokes `ReleaseUnreferenced` to be uncaught. We pass an already canceled context to the method which causes any implementations that do check the context to always fail. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
30b196c to
b853c78
Compare
The existing implementations do not check for the context being canceled
when
ReleaseUnreferencedis called which has caused a bug in how thecontroller invokes
ReleaseUnreferencedto be uncaught. We pass analready canceled context to the method which causes any implementations
that do check the context to always fail.