Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: frontend/dockerfile: update integration tests for windows/wcow (revisited) #5526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

profnandaa
Copy link
Collaborator

@profnandaa profnandaa commented Nov 18, 2024

This is a continuation for the integration tests work #4485 We had some tests that we marked as Revit during our first pass through the tests.

This commit addresses the following tests in frontedn/dockerfile:

  • testNamedOCILayoutContext
  • testArgDefaultExpansion
  • testTargetStageNameArg
  • testContextChangeDirToFile (once reported flaky, fixes Flaky test: TestContextChangeDirToFile #5384 )
  • testGlobalArgErrors
  • testCopyThroughSymlinkMultiStage
  • testTarContextExternalDockerfile
  • testTarContext
  • testOutlineArgs

@profnandaa profnandaa force-pushed the tests-4485-revisit-frontend-2 branch 3 times, most recently from dae3a91 to e4d8356 Compare December 17, 2024 07:23
@profnandaa profnandaa force-pushed the tests-4485-revisit-frontend-2 branch 3 times, most recently from 2c5d6c9 to 723060b Compare December 18, 2024 07:48
This is a continuation for the integration tests work moby#4485
We had some tests that we marked as Revit during our first pass
through the tests.

This commit addresses the following tests in `frontend/dockerfile`:

- [x] `testNamedOCILayoutContext`
- [x] `testArgDefaultExpansion`
- [x] `testTargetStageNameArg`
- [x] `testContextChangeDirToFile` (once reported flaky, fixes moby#5384 )
- [x] `testGlobalArgErrors`
- [x] `testCopyThroughSymlinkMultiStage`
- [x] `testTarContextExternalDockerfile`
- [x] `testTarContext`
- [x] `testOutlineArgs`

Count: 8 (+1)

Signed-off-by: Anthony Nandaa <[email protected]>
@profnandaa profnandaa force-pushed the tests-4485-revisit-frontend-2 branch from 723060b to 7fa6d57 Compare December 18, 2024 08:39
@profnandaa profnandaa marked this pull request as ready for review December 18, 2024 10:56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: TestContextChangeDirToFile
2 participants