Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated imports for v16 datatypes, call and call_result files #698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jainmohit2001
Copy link
Collaborator

Changes included in this PR

Updated imports for call.py, call_result.py and datatypes.py for ocpp/v16 module.

Current behavior

Previously the imports included individual classes which are not consistent with the changes done in ocpp/v201 module.

New behavior

No changes in existing behavior. Now the imports are being done on a module level instead of individual classes.

Impact

N/A

Checklist

  1. Does your submission pass the existing tests?
  2. Are there new tests that cover these additions/changes?
  3. Have you linted your code locally before submission?

@jainmohit2001
Copy link
Collaborator Author

@proelke, I have updated the imports for ocpp/v16 as discussed in #680 (comment)

@jainmohit2001
Copy link
Collaborator Author

@proelke feel free to review this and let me know if we need any other changes.

@jainmohit2001
Copy link
Collaborator Author

@mdwcrft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant