-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add code of conduct, contributing, security and support docs. #681
chore: Add code of conduct, contributing, security and support docs. #681
Conversation
Thanks for the PR! You have covered almost everything. |
contributing was inspired by: https://github.com/probot/template/blob/master/CONTRIBUTING.md security was inspired by:
support from: pull request based on a few of the examples here: think that should cover all the primary sources i used. |
| 2.0.0 | :white_check_mark: | | ||
| 0.26.0 | :white_check_mark: | | ||
| < 0.26.0 | :x: | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerome-benoit actually, maybe there has been a release? I see releases listed in the changelog and there are tags listed, although none of them are listed in github as a release. and pypi has ocpp 1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but github's releases only have 0.26.0 as the last official release, although there is a 1.0.0-rc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the current state of affair, an automated release process syncing deterministically future versions between GitHub and pypi has higher priority than the others comment I've done on that file in the other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerome-benoit just submitted a new PR #688 which changes the release workflow process to use the same version in pyproject.toml to publish to pypi, create a git tag and create a github release. Let me know if this addresses your concern?
LGTM |
efa2736
to
47f7308
Compare
@proelke @mdwcrft @jerome-benoit, do we need to make any changes in this PR? |
Also includes a pull request template. Contributes to mobilityhouse#671
47f7308
to
ef0294b
Compare
Co-authored-by: Chad <[email protected]>
Co-authored-by: Chad <[email protected]>
Based on examples from other open-source repos in github:
Contributes to #671