Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add code of conduct, contributing, security and support docs. #681

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

ajmirsky
Copy link
Contributor

Based on examples from other open-source repos in github:

  • code of conduct for those participating in the project
  • instructions for contributing to the project (including a pull request template to help facilitate)
  • how to report a security vulnerability
  • expectations of getting help with the project

Contributes to #671

@jainmohit2001
Copy link
Collaborator

jainmohit2001 commented Nov 25, 2024

Thanks for the PR! You have covered almost everything.
Another request. Can you please share the reference/source if you have used one?
For COC, its already there, but for the rest, I think we can mention the reference in the PR (as a comment, NOT as a commit).

@ajmirsky
Copy link
Contributor Author

ajmirsky commented Nov 25, 2024

| 2.0.0 | :white_check_mark: |
| 0.26.0 | :white_check_mark: |
| < 0.26.0 | :x: |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerome-benoit actually, maybe there has been a release? I see releases listed in the changelog and there are tags listed, although none of them are listed in github as a release. and pypi has ocpp 1.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but github's releases only have 0.26.0 as the last official release, although there is a 1.0.0-rc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the current state of affair, an automated release process syncing deterministically future versions between GitHub and pypi has higher priority than the others comment I've done on that file in the other PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerome-benoit just submitted a new PR #688 which changes the release workflow process to use the same version in pyproject.toml to publish to pypi, create a git tag and create a github release. Let me know if this addresses your concern?

@ajmirsky ajmirsky mentioned this pull request Dec 8, 2024
jainmohit2001
jainmohit2001 previously approved these changes Dec 9, 2024
@jainmohit2001
Copy link
Collaborator

LGTM

@jainmohit2001 jainmohit2001 force-pushed the issue/671_project_docs branch from efa2736 to 47f7308 Compare December 9, 2024 09:27
@jainmohit2001
Copy link
Collaborator

@proelke @mdwcrft @jerome-benoit, do we need to make any changes in this PR?

@jainmohit2001 jainmohit2001 force-pushed the issue/671_project_docs branch from 47f7308 to ef0294b Compare December 9, 2024 13:28
@jainmohit2001 jainmohit2001 changed the title Add code of conduct, contributing, security and support docs. chore: Add code of conduct, contributing, security and support docs. Dec 9, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jainmohit2001 jainmohit2001 merged commit cf21e48 into mobilityhouse:master Dec 9, 2024
8 checks passed
@jainmohit2001 jainmohit2001 mentioned this pull request Dec 9, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants