Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable threads if messages.ASYNC_VALIDATION = False #678

Merged
merged 3 commits into from
Dec 7, 2024
Merged

Disable threads if messages.ASYNC_VALIDATION = False #678

merged 3 commits into from
Dec 7, 2024

Conversation

astrand
Copy link
Contributor

@astrand astrand commented Nov 18, 2024

See discussion at #676

@astrand astrand mentioned this pull request Nov 18, 2024
Closed
@jainmohit2001
Copy link
Collaborator

Thanks for the great PR and in-depth discussion. Really appreciate the time you have spent to ensure backward compatibility.
Can you please add a test where we set the ASYNC_VALIDATION variable to True?

@astrand astrand force-pushed the configurable-threads branch from 680c378 to 05f9ec0 Compare November 20, 2024 09:49
@jainmohit2001 jainmohit2001 merged commit 0dc23fb into mobilityhouse:master Dec 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proelke proelke proelke approved these changes

@mdwcrft mdwcrft Awaiting requested review from mdwcrft mdwcrft is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astrand @jainmohit2001 @proelke