Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle responder_url edge case #336

Closed
wants to merge 6 commits into from
Closed

Handle responder_url edge case #336

wants to merge 6 commits into from

Conversation

proelke
Copy link
Collaborator

@proelke proelke commented May 11, 2022

In the 2.0.1 spec for AuthorizeRequest and GetCertificateStatusRequest there is a field responderURL that does not get converted from snake_case responder_url to camelCase responderURL. This PR adds handling of this edge case. in SetNetworkProfileRequest there is a field ocppCsmsUrl which is handled correctly but causes problems for a more general solution.

Let me know if the conditionals work for you.

@proelke proelke requested review from OrangeTux and tropxy as code owners May 11, 2022 15:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tropxy
tropxy previously approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@tropxy tropxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebasing

@Jared-Newell-Mobility Jared-Newell-Mobility mentioned this pull request Dec 22, 2023
Closed
@OrangeTux
Copy link
Contributor

@Jared-Newell-Mobility This one is also required for a v1 release. You can take it over the issue and finish it.

@Jared-Newell-Mobility Jared-Newell-Mobility mentioned this pull request Feb 5, 2024
Closed
@Jared-Newell-Mobility
Copy link
Contributor

Thanks for highlighting this, it has been replaced with PR #592, so it will close for now

@Jared-Newell-Mobility Jared-Newell-Mobility mentioned this pull request Feb 14, 2024
Merged
Jared-Newell-Mobility added a commit that referenced this pull request Feb 14, 2024
@Jared-Newell-Mobility
Bump to 1.0.0-rc.1 (#611)
dbfb006 
## 1.0.0-rc.1 (2024-02-14)

- [#573](#573) Introduce
Experimental Module For v2.1
- [#547](#547) Feat: Handle
recursively serializing a dataclasses as a dictionary Thanks
[@MacDue](https://github.com/MacDue)
- [#601](#601) Fix case
conversion for soc in non "State of Charge" context
- [#523](#523) The
serialisation of soc to SoC should not occur in camel case if it is
existing at the beginning of a field
- [#515](#515) Update
Readthedocs configuration
- [#602](#602) Correct v2g
serialisation/deserialisation
- [#557](#557) OCPP 2.0.1
Wrong data type in CostUpdated total_cost
- [#564](#564) Add support
For Python 3.11 and 3.12
- [#583](#583) OCPP
v1.6/v2.0.1 deprecate dataclasses from calls and call results with the
suffix 'Payload'
- [#590](#336)
snake_to_camel_case url to URL does not get converted correctly
- [#591](#591)
Camel_to_snake_case doesn't handle v2x correctly
- [#593](#593) Update tests
to use Call and CallResult without the suffix Payload
- [#435](#435) Typo in
CostUpdated Action
- [#577](#577) v2.0.1
AttributeType Enum Corrections
- [#340](#340) 2.0.1
dataclasses have a incorrect types that don't match carnality
- [#519](#519) Typo in
v201.enums.StatusInfoReasonType.invaild_schedule
- [#510](#510) v2.0.1
UnitOfMeasureType - Enums missing and update docstring to allow use for
variableCharacteristics
- [#508](#508) Exception -
OccurrenceConstraintViolationError doc string correction

## DEPRECATED ##
- [#599](#599) v1.6 Action
Enum members corrected IMPORTANT SEE UPGRADE PATH
[#599](#599)
- [#579](#579) v2.0.1 Action
enums corrected - IMPORTANT SEE UPGRADE PATH
[#579](#579)

## BREAKING ##
- [#574](#574) Remove v1.6
deprecated enum members - IMPORTANT see upgrade path
[#574](#574)
- [#498](#498) Remove
support for OCPP 2.0 - IMPORTANT SEE UPGRADE PATH
[#498](#498)
RoaringDev1203 added a commit to RoaringDev1203/Cratus-OCPP that referenced this pull request Aug 27, 2024
@RoaringDev1203
Bump to 1.0.0-rc.1 (#611)
d3b7fe6 
## 1.0.0-rc.1 (2024-02-14)

- [#573](mobilityhouse/ocpp#573) Introduce
Experimental Module For v2.1
- [#547](mobilityhouse/ocpp#547) Feat: Handle
recursively serializing a dataclasses as a dictionary Thanks
[@MacDue](https://github.com/MacDue)
- [#601](mobilityhouse/ocpp#601) Fix case
conversion for soc in non "State of Charge" context
- [#523](mobilityhouse/ocpp#523) The
serialisation of soc to SoC should not occur in camel case if it is
existing at the beginning of a field
- [#515](mobilityhouse/ocpp#515) Update
Readthedocs configuration
- [#602](mobilityhouse/ocpp#602) Correct v2g
serialisation/deserialisation
- [#557](mobilityhouse/ocpp#557) OCPP 2.0.1
Wrong data type in CostUpdated total_cost
- [#564](mobilityhouse/ocpp#564) Add support
For Python 3.11 and 3.12
- [#583](mobilityhouse/ocpp#583) OCPP
v1.6/v2.0.1 deprecate dataclasses from calls and call results with the
suffix 'Payload'
- [#590](mobilityhouse/ocpp#336)
snake_to_camel_case url to URL does not get converted correctly
- [#591](mobilityhouse/ocpp#591)
Camel_to_snake_case doesn't handle v2x correctly
- [#593](mobilityhouse/ocpp#593) Update tests
to use Call and CallResult without the suffix Payload
- [#435](mobilityhouse/ocpp#435) Typo in
CostUpdated Action
- [#577](mobilityhouse/ocpp#577) v2.0.1
AttributeType Enum Corrections
- [#340](mobilityhouse/ocpp#340) 2.0.1
dataclasses have a incorrect types that don't match carnality
- [#519](mobilityhouse/ocpp#519) Typo in
v201.enums.StatusInfoReasonType.invaild_schedule
- [#510](mobilityhouse/ocpp#510) v2.0.1
UnitOfMeasureType - Enums missing and update docstring to allow use for
variableCharacteristics
- [#508](mobilityhouse/ocpp#508) Exception -
OccurrenceConstraintViolationError doc string correction

## DEPRECATED ##
- [#599](mobilityhouse/ocpp#599) v1.6 Action
Enum members corrected IMPORTANT SEE UPGRADE PATH
[#599](mobilityhouse/ocpp#599)
- [#579](mobilityhouse/ocpp#579) v2.0.1 Action
enums corrected - IMPORTANT SEE UPGRADE PATH
[#579](mobilityhouse/ocpp#579)

## BREAKING ##
- [#574](mobilityhouse/ocpp#574) Remove v1.6
deprecated enum members - IMPORTANT see upgrade path
[#574](mobilityhouse/ocpp#574)
- [#498](mobilityhouse/ocpp#498) Remove
support for OCPP 2.0 - IMPORTANT SEE UPGRADE PATH
[#498](mobilityhouse/ocpp#498)
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this pull request Nov 26, 2024
@Jared-Newell-Mobility
Bump to 1.0.0-rc.1 (mobilityhouse#611)
3dce54f 
## 1.0.0-rc.1 (2024-02-14)

- [mobilityhouse#573](mobilityhouse#573) Introduce
Experimental Module For v2.1
- [mobilityhouse#547](mobilityhouse#547) Feat: Handle
recursively serializing a dataclasses as a dictionary Thanks
[@MacDue](https://github.com/MacDue)
- [mobilityhouse#601](mobilityhouse#601) Fix case
conversion for soc in non "State of Charge" context
- [mobilityhouse#523](mobilityhouse#523) The
serialisation of soc to SoC should not occur in camel case if it is
existing at the beginning of a field
- [mobilityhouse#515](mobilityhouse#515) Update
Readthedocs configuration
- [mobilityhouse#602](mobilityhouse#602) Correct v2g
serialisation/deserialisation
- [mobilityhouse#557](mobilityhouse#557) OCPP 2.0.1
Wrong data type in CostUpdated total_cost
- [mobilityhouse#564](mobilityhouse#564) Add support
For Python 3.11 and 3.12
- [mobilityhouse#583](mobilityhouse#583) OCPP
v1.6/v2.0.1 deprecate dataclasses from calls and call results with the
suffix 'Payload'
- [mobilityhouse#590](mobilityhouse#336)
snake_to_camel_case url to URL does not get converted correctly
- [mobilityhouse#591](mobilityhouse#591)
Camel_to_snake_case doesn't handle v2x correctly
- [mobilityhouse#593](mobilityhouse#593) Update tests
to use Call and CallResult without the suffix Payload
- [mobilityhouse#435](mobilityhouse#435) Typo in
CostUpdated Action
- [mobilityhouse#577](mobilityhouse#577) v2.0.1
AttributeType Enum Corrections
- [mobilityhouse#340](mobilityhouse#340) 2.0.1
dataclasses have a incorrect types that don't match carnality
- [mobilityhouse#519](mobilityhouse#519) Typo in
v201.enums.StatusInfoReasonType.invaild_schedule
- [mobilityhouse#510](mobilityhouse#510) v2.0.1
UnitOfMeasureType - Enums missing and update docstring to allow use for
variableCharacteristics
- [mobilityhouse#508](mobilityhouse#508) Exception -
OccurrenceConstraintViolationError doc string correction

## DEPRECATED ##
- [mobilityhouse#599](mobilityhouse#599) v1.6 Action
Enum members corrected IMPORTANT SEE UPGRADE PATH
[mobilityhouse#599](mobilityhouse#599)
- [mobilityhouse#579](mobilityhouse#579) v2.0.1 Action
enums corrected - IMPORTANT SEE UPGRADE PATH
[mobilityhouse#579](mobilityhouse#579)

## BREAKING ##
- [mobilityhouse#574](mobilityhouse#574) Remove v1.6
deprecated enum members - IMPORTANT see upgrade path
[mobilityhouse#574](mobilityhouse#574)
- [mobilityhouse#498](mobilityhouse#498) Remove
support for OCPP 2.0 - IMPORTANT SEE UPGRADE PATH
[mobilityhouse#498](mobilityhouse#498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tropxy tropxy tropxy left review comments

@OrangeTux OrangeTux Awaiting requested review from OrangeTux

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@proelke @OrangeTux @Jared-Newell-Mobility @tropxy