Bump C++ version to C++17 #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protobuf versions since 3.6.0 have long had a C++11 dependency; even more recent versions have picked up an Abseil dependency bumping that to C++14. Since it is now 2023, defaulting to C++17 is reasonable, so remove the conditional C++ standards version check that mosh previously had and replace it with an unconditional C++17 check. This means that all future commits can use C++17 features. According to https://en.cppreference.com/w/cpp/compiler_support/17 this means that minimum effective compiler versions for mosh become: gcc 7 (May 2017) clang 5 (September 2017) This, in turn, implies that future versions of mosh will no longer be available for RHEL/CentOS 7 (June 2014). Closes: mobile-shell#1267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf versions since 3.6.0 have long had a C++11 dependency; even more recent versions have picked up an Abseil dependency bumping that to C++14. Since it is now 2023, defaulting to C++17 is reasonable, so remove the conditional C++ standards version check that mosh previously had and replace it with an unconditional C++17 check.
This means that all future commits can use C++17 features. According to https://en.cppreference.com/w/cpp/compiler_support/17 this means that minimum effective compiler versions for mosh become:
gcc 7 (May 2017)
clang 5 (September 2017)
This, in turn, implies that future versions of mosh will no longer be available for RHEL/CentOS 7 (June 2014).
Closes: #1267