Use pipe to communicate between client and server at startup #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achernya
reviewed
Feb 3, 2023
I don't think this fixes anything? In the prior mosh-server code, that read/write on the pty are before any user data passes across it, the newline should never be seen by the user. The problems with excess newlines are in mosh.pl, at least in my experience. I am concerned about the additional complexity added by this commit. At the very least, |
Empirically, it is being seen by the user. |
|
@ahedberg I fixed the CI config, I believe if you rebase and push CI should be clean. |
Fixes empty line on login
achernya
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1142