Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pipe to communicate between client and server at startup #1255

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

ahedberg
Copy link
Contributor

@ahedberg ahedberg commented Feb 3, 2023

Fixes #1142

Copy link
Collaborator

@achernya achernya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we augment the git commit description with how this commit works? The PR description won't show up in the git log

src/frontend/mosh-server.cc Show resolved Hide resolved
@cgull
Copy link
Member

cgull commented Jul 19, 2023

Fixes #1142

I don't think this fixes anything? In the prior mosh-server code, that read/write on the pty are before any user data passes across it, the newline should never be seen by the user. The problems with excess newlines are in mosh.pl, at least in my experience.

I am concerned about the additional complexity added by this commit. At the very least, CLOEXEC should be set on the pipe fds.

@achernya
Copy link
Collaborator

that read/write on the pty are before any user data passes across it, the newline should never be seen by the user.

Empirically, it is being seen by the user.

@achernya
Copy link
Collaborator

@ahedberg I fixed the CI config, I believe if you rebase and push CI should be clean.

@achernya achernya merged commit 4306b7c into mobile-shell:master Aug 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mosh clears the terminal and adds an empty lines on login
3 participants