Fix off-by-one when specifying count with inputText #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
… of taps occur Repeated tests show that the emulator can be slightly inconsistent and occasionally add an extra tap
Fishbowler
force-pushed
the
fix-eraseText-offByOne
branch
from
47c1305
to
e75a143
Compare
| uiDevice.pressDelete() | ||
| Thread.sleep(50) // Attempt to ensure perfect count of taps on emulators |
There was a problem hiding this comment.
Wouldn't encourage doing this. Let's avoid having random sleeps in the code. It becomes very hard to reason about slowness and failures due to these.
Can you explain why is this exactly needed and if there is something other than a sleep we could do?
There was a problem hiding this comment.
Before this sleep was in, I'd occasionally see 1 extra or 1 too few presses of the delete key.
There was a problem hiding this comment.
There's a chance that shorter sleeps would be sufficient, or that the API could be improved to block until ready?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Self-evident 1 character change to fix a problem where we're always deleting 1 character extra. Background in the linked issue.
Testing
Issues fixed
#2122