Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure only one xcodebuild process, cleanup unwanted retries #2097

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ensure only one xcodebuild process, cleanup unwanted retries #2097

wants to merge 3 commits into from
+85 −387

Conversation

amanjeetsingh150
Copy link
Collaborator

@amanjeetsingh150 amanjeetsingh150 commented Oct 16, 2024 •
edited
Loading

Proposed changes

  1. The timeout 100 seconds is not enough for some calls.
  2. Adds a known exception and a call name to track such calls
  3. Retries are not cleaned up properly due to which multiple xcodebuild processes end up alive at one time. Change the way we start driver.

Testing

  • Locally

Issues fixed

#1585

@amanjeetsingh150 amanjeetsingh150 force-pushed the refactor-retries-driver-install branch 2 times, most recently from 4e88f87 to 622892b Compare November 17, 2024 13:04
@amanjeetsingh150 amanjeetsingh150 changed the title Refactor LocalXCInstaller to handle retries properly and cleanup Ensure only one xcodebuild process, cleanup unwanted retries Nov 17, 2024
@amanjeetsingh150 amanjeetsingh150 force-pushed the refactor-retries-driver-install branch 2 times, most recently from f34f10d to 7b537e9 Compare November 18, 2024 14:36
@amanjeetsingh150 amanjeetsingh150 marked this pull request as ready for review November 18, 2024 17:46
herval
herval reviewed Nov 18, 2024
View reviewed changes
maestro-ios-driver/src/main/kotlin/xcuitest/api/OkHttpClientInstance.kt
import okhttp3.OkHttpClient
import java.util.concurrent.TimeUnit

object OkHttpClientInstance {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will lead to multiple places using the same configuration for http connection, which is bad (some situations might require larger timeouts, some might require smaller pools, etc. I dont think it's a good idea

maestro-ios-driver/src/main/kotlin/xcuitest/api/OkHttpClientInstance.kt

fun get(): OkHttpClient {
return OkHttpClient.Builder()
.connectionPool(ConnectionPool(225, 10, TimeUnit.MINUTES))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 225?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herval herval herval left review comments

@igorsmotto igorsmotto Awaiting requested review from igorsmotto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanjeetsingh150 @herval